feat(rust/cbork): Add report_duplicated_key and report_missing_keys functions to the cbork-utils crate #178
+33
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
report_duplicated_key
andreport_missing_keys
functions to thecbork-utils
crate.Description of Changes
It is rather common pattern in the
Decode
trait implementation to check for report duplicated keys and check presence of the required ones. For example in CIP-36 decoding and CIP-509 decoding. I'm not sure ifcbork-utils
is the best place for these functions, but it would be nice to reuse them instead of having several almost identical implementations.Please confirm the following checks