Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render avatar, profile and self in format json #166

Merged
merged 4 commits into from
Apr 3, 2015

Conversation

echox
Copy link
Contributor

@echox echox commented Mar 15, 2015

Fix for Issue #164 (added self and avatar to json)

@mvitz
Copy link
Contributor

mvitz commented Mar 15, 2015

Thanks for your contribution.

  1. I think the self link should point to the 'status' and not to the 'author'!
  2. I personally favour that each commit is buildable. Maybe you could squash the first two and the last two together?
  3. Maybe you could add some tests for the JSON rendering.

I'm going to merge this PR once at least 1. is fixed.

@echox
Copy link
Contributor Author

echox commented Mar 15, 2015

Ok:

  1. You are correct, I still keep the profile link as an addition :-)
  2. done.
  3. done, a test for routes.clj should be also added at some point.

@echox echox changed the title Render avatar and profile in format json Render avatar, profile and self in format json Mar 15, 2015
@FND
Copy link
Contributor

FND commented Mar 16, 2015

I personally favour that each commit is buildable

FWIW, I think it's more important for commits to be atomic. However, it's nice if the set of commits being pushed (hopefully still reasonably small) is CI compliant.

@mvitz
Copy link
Contributor

mvitz commented Mar 16, 2015

I agree. But for me atomic includes that the code works...

I never would commit a call to a new function first and the function itself in a separate commit afterwards.

@mvitz
Copy link
Contributor

mvitz commented Mar 30, 2015

@echox is this PR complete or is there anything missing?

@echox
Copy link
Contributor Author

echox commented Mar 30, 2015

should be complete :-)

@mvitz
Copy link
Contributor

mvitz commented Mar 30, 2015

Thanks, I will have a look at it at the weekend.

@mvitz mvitz merged commit 53d3186 into innoq:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants