-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render avatar, profile and self in format json #166
Conversation
Thanks for your contribution.
I'm going to merge this PR once at least 1. is fixed. |
… with the usage of avatar-path)
Ok:
|
FWIW, I think it's more important for commits to be atomic. However, it's nice if the set of commits being pushed (hopefully still reasonably small) is CI compliant. |
I agree. But for me atomic includes that the code works... I never would commit a call to a new function first and the function itself in a separate commit afterwards. |
@echox is this PR complete or is there anything missing? |
should be complete :-) |
Thanks, I will have a look at it at the weekend. |
Fix for Issue #164 (added self and avatar to json)