Allow custom strategy for handling invalid cookies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvitz
force-pushed
the
feature/issue-1_invalid-cookie-failure-handling-strategy
branch
from
c5e8562 to
83913ee
Compare
cstettler
reviewed
Jul 11, 2018
| @@ -87,16 +97,14 @@ protected Object getFlashMapsMutex(HttpServletRequest request) { | |||
| private List<FlashMap> decode(String value) { | |||
| final String[] signatureAndPayload = reverse(value).split("--", 2); | |||
| if (signatureAndPayload.length != 2) { | |||
| // TODO logging | |||
| return null; | |||
| return verificationFailureHandler.onInvalidValue(value); | |||
There was a problem hiding this comment.
What is the semantics of this failure, i.e. what went wrong? And is is worth distinguishing between onInvalidValue() and onInvalidSignature()? In both cases, the content of the cookie was not as expected.
cstettler
reviewed
Jul 11, 2018
|
|
||
| List<FlashMap> onInvalidValue(String value); | ||
|
|
||
| List<FlashMap> onInvalidSignature(String payload, String signature); |
There was a problem hiding this comment.
Would it be legal to throw e.g. an IllegalStateException in case the signature is invalid? I assume that would lead to a 500 in Spring MVC, which would be good.
mvitz
force-pushed
the
feature/issue-1_invalid-cookie-failure-handling-strategy
branch
from
83913ee to
f4923fc
Compare
This feature allows to customise the behaviour of what should be done in case the cookie can not be verified. By default the cookie is silently ignored, as before. Closes #1
mvitz
force-pushed
the
feature/issue-1_invalid-cookie-failure-handling-strategy
branch
from
f4923fc to
6d9bd90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
CookieVerificationFailureHandlerwhich can be used to customise the behaviour for handling invalid cookies.Closes #1