-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General Cleanup For Cocoapods #57
Open
twof
wants to merge
18
commits into
inloop:master
Choose a base branch
from
redbooth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c10e3fe
updated for redbooth
alan-yilun-li 1f01011
Updated to swift 4
twof f67c889
Merge pull request #1 from redbooth/swift4
alan-yilun-li bb40b29
made changes to add xcode10 and swift 4.2 support
rahuljiresal ddf71eb
renamed a variable
rahuljiresal 570d335
Merge pull request #2 from redbooth/fix/xcode10
rahuljiresal f025dec
Merge branch 'om' into fix/iOS12
rahuljiresal 783e2d8
Merge pull request #3 from redbooth/fix/iOS12
rahuljiresal 7d959cd
removed Redbooth remanents
twof 7bb5c31
Merge pull request #4 from redbooth/prepForRelease
twof 9bf399e
cleanup for cocoapods release
twof df9aaee
Merge pull request #5 from redbooth/prepForRelease
twof 5be6b5b
update podspec to redboothImagePicker
twof deff9af
podspec passing
twof 597cbdc
- Updated to Swift 5
xavisavvy d5b41f5
Updated gitignore, and podspec version
xavisavvy d35ab90
Merge pull request #6 from redbooth/swift-5-upgrade
xavisavvy 6c09618
Added XCode 12 fixes for unknown returns in switches.
xavisavvy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file added
BIN
+39.7 KB
...codeproj/project.xcworkspace/xcuserdata/alanli.xcuserdatad/UserInterfaceState.xcuserstate
Binary file not shown.
Binary file added
BIN
+33.9 KB
...odeproj/project.xcworkspace/xcuserdata/newuser.xcuserdatad/UserInterfaceState.xcuserstate
Binary file not shown.
Binary file added
BIN
+30.5 KB
...xcodeproj/project.xcworkspace/xcuserdata/rahul.xcuserdatad/UserInterfaceState.xcuserstate
Binary file not shown.
19 changes: 19 additions & 0 deletions
19
ImagePicker.xcodeproj/xcuserdata/alanli.xcuserdatad/xcschemes/xcschememanagement.plist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>SchemeUserState</key> | ||
<dict> | ||
<key>ExampleApp.xcscheme</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>1</integer> | ||
</dict> | ||
<key>ImagePicker.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>0</integer> | ||
</dict> | ||
</dict> | ||
</dict> | ||
</plist> |
24 changes: 24 additions & 0 deletions
24
ImagePicker.xcodeproj/xcuserdata/newuser.xcuserdatad/xcschemes/xcschememanagement.plist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>SchemeUserState</key> | ||
<dict> | ||
<key>ExampleApp.xcscheme</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>1</integer> | ||
</dict> | ||
<key>ExampleApp.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>1</integer> | ||
</dict> | ||
<key>ImagePicker.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>0</integer> | ||
</dict> | ||
</dict> | ||
</dict> | ||
</plist> |
19 changes: 19 additions & 0 deletions
19
ImagePicker.xcodeproj/xcuserdata/rahul.xcuserdatad/xcschemes/xcschememanagement.plist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>SchemeUserState</key> | ||
<dict> | ||
<key>ExampleApp.xcscheme</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>1</integer> | ||
</dict> | ||
<key>ImagePicker.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>0</integer> | ||
</dict> | ||
</dict> | ||
</dict> | ||
</plist> |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,30 +9,38 @@ | |
import Foundation | ||
import UIKit | ||
|
||
final class ActionCell : UICollectionViewCell { | ||
|
||
@IBOutlet weak var titleLabel: UILabel! | ||
@IBOutlet weak var imageView: UIImageView! | ||
|
||
public final class ActionCell : UICollectionViewCell { | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't use extra opening lines |
||
@IBOutlet public weak var backgroundImageView: UIImageView! | ||
@IBOutlet public weak var titleLabel: UILabel! | ||
@IBOutlet public weak var imageView: UIImageView! | ||
|
||
@IBOutlet var leadingOffset: NSLayoutConstraint! | ||
@IBOutlet var trailingOffset: NSLayoutConstraint! | ||
@IBOutlet var topOffset: NSLayoutConstraint! | ||
@IBOutlet var bottomOffset: NSLayoutConstraint! | ||
override func awakeFromNib() { | ||
|
||
override public func awakeFromNib() { | ||
super.awakeFromNib() | ||
imageView.backgroundColor = UIColor.clear | ||
} | ||
|
||
} | ||
|
||
extension ActionCell { | ||
|
||
|
||
public func setupOffsets() { | ||
topOffset.constant = 5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. DRY, keep 5 to a constant |
||
bottomOffset.constant = 5 | ||
leadingOffset.constant = 5 | ||
trailingOffset.constant = 5 | ||
} | ||
|
||
func update(withIndex index: Int, layoutConfiguration: LayoutConfiguration) { | ||
|
||
let layoutModel = LayoutModel(configuration: layoutConfiguration, assets: 0) | ||
let actionCount = layoutModel.numberOfItems(in: layoutConfiguration.sectionIndexForActions) | ||
|
||
titleLabel.textColor = UIColor.black | ||
switch index { | ||
case 0: | ||
|
@@ -43,10 +51,10 @@ extension ActionCell { | |
imageView.image = UIImage(named: "button-photo-library", in: Bundle(for: type(of: self)), compatibleWith: nil) | ||
default: break | ||
} | ||
|
||
let isFirst = index == 0 | ||
let isLast = index == actionCount - 1 | ||
|
||
switch layoutConfiguration.scrollDirection { | ||
case .horizontal: | ||
topOffset.constant = isFirst ? 10 : 5 | ||
|
@@ -59,7 +67,8 @@ extension ActionCell { | |
leadingOffset.constant = isFirst ? 10 : 5 | ||
trailingOffset.constant = isLast ? 10 : 5 | ||
} | ||
|
||
} | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix alignment