S3 url fix #71
Closed
S3 url fix #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
commented
Jan 31, 2020
| @@ -4,11 +4,12 @@ type input = AbortMultipartUploadRequest.t | |||
| type output = AbortMultipartUploadOutput.t | |||
| type error = Errors_internal.t | |||
| let service = "s3" | |||
| let to_http service region req = | |||
| let to_http service region (req : input) = | |||
There was a problem hiding this comment.
We infer the wrong type here if there is no annotation. It really shouldn't be necessary.
tmcgilchrist
force-pushed
the
topic/s3_url_fix
branch
from
b1b8df5 to
2c044d2
Compare
tmcgilchrist
force-pushed
the
topic/s3_url_fix
branch
from
49791c1 to
b89a998
Compare
tmcgilchrist
force-pushed
the
topic/s3_url_fix
branch
from
b89a998 to
5912b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated URLs for S3 need to include the bucket name (except for Listing Buckets).
@tmattio If you have some code to run against this please give it a go.
make aws-s3to regenerate the S3 bindings if you need.Fix for #70