Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add sqs #55

Closed
wants to merge 12 commits into from
Closed

Feature/add sqs #55

wants to merge 12 commits into from

Conversation

pm-mck
Copy link

@pm-mck pm-mck commented Mar 9, 2019 •
edited
Loading

Attempt at adding SQS support for #55

@pm-mck pm-mck mentioned this pull request Mar 9, 2019
Closed
@Leonidas-from-XIV
Copy link
Contributor

@pm-mck Are you still working on this? Some of your changes would be very useful to have to get #60 to work, since it suffers from the same problem with the generator, building invalid URLs.

@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Aug 1, 2019
Open
@pm-mck
Copy link
Author

pm-mck commented Aug 1, 2019

@Leonidas-from-XIV I'm happy to keep working on this one, just hasn't had much momentum. I might have made the PR too big here :(

@tmcgilchrist
Copy link
Collaborator

I've hacked on this on another branch here #63 and made CI happy. @pm-mck

@tmcgilchrist
Copy link
Collaborator

Thanks I've merged this under #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-mck @Leonidas-from-XIV @tmcgilchrist