Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http protocol to connect to localhost #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use http protocol to connect to localhost #121

wants to merge 1 commit into from

Conversation

Nymphium
Copy link
Contributor

@Nymphium Nymphium commented Mar 28, 2022 •
edited
Loading

DynamoDB local can only communicate HTTP.

This PR depends on #125.

@Nymphium Nymphium mentioned this pull request Mar 28, 2022
Draft
@Nymphium Nymphium force-pushed the http-localhost-endpoint branch 3 times, most recently from ec483f2 to 8e2e2fc Compare March 31, 2022 05:08
@Nymphium Nymphium mentioned this pull request Mar 31, 2022
Merged
@Nymphium Nymphium changed the title Use http protocol to connect to dynamodb local Use http protocol to connect to localhost Mar 31, 2022
@Nymphium Nymphium force-pushed the http-localhost-endpoint branch from 8e2e2fc to faa2728 Compare March 31, 2022 05:33
@tmcgilchrist
Copy link
Collaborator

Thanks @Nymphium I haven't had time to test this for myself but it's on the list. :-)
If DynamoDB local is available as a docker container, then writing some integration style tests against that container would be a great addition to this project's CI.

@Nymphium Nymphium force-pushed the http-localhost-endpoint branch from faa2728 to 090f332 Compare November 14, 2022 08:03
@Nymphium Nymphium force-pushed the http-localhost-endpoint branch from 090f332 to 41c7a8f Compare July 10, 2023 16:55
@tmcgilchrist
Copy link
Collaborator

I've merged #125 @Nymphium looks like this PR could use an update.

@Nymphium Nymphium force-pushed the http-localhost-endpoint branch from 41c7a8f to 0053146 Compare July 16, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nymphium @tmcgilchrist