KMS: add KMS support #118
Merged
KMS: add KMS support #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
requested changes
Mar 30, 2022
There was a problem hiding this comment.
Really nice work @zbaylin, the overriding of the resultWrapper looks right.
Could I ask you to squash your work into 2 commits; 1 for the fixes to the generator and associated botocore overrides, and a second commit that just includes the generated code.
Please include a line in the CHANGES.md under #Unreleased with a short description of your changes and a link back to this PR. Many thanks for the contribution.
|
@tmcgilchrist sure! I'll do that and force push. Thanks for the review! |
tmcgilchrist
approved these changes
Apr 3, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for AWS's Key Management Service.
Unfortunately the service definitions provided by botocore do not provide the necessary
resultWrappers(boto/botocore#2576), so I had to modify the override system a bit to add those in.