Exposes surf's with_http_client

[ctrlaltf24]

Description

Exposed Surf's with_http_client to allow users to more granularity in their HTTP clients. One use case is creating a isahc HttpClient with HTTP basic auth

let http_client = isahc::HttpClientBuilder::new().authentication(Authentication::basic()).build()?;
let http_client = IsahcClient::from_client(http_client);
let client = Client::new("username:password@domain.com", "database").with_auth("user", "pass").with_http_client(http_client);

Maintenance considerations

If the project moves away from surf this function will need to be under a surf feature. This function does make moving away from surf a semver major change, looking at #92 it appears a sermver breaking change when moving away from surf is planned.

Checklist

• Formatted code using cargo fmt --all
• Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • NOTE: There are a couple existing errors trait objects without an explicit dyn are deprecated.
• Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
• Reviewed the diff. Did you leave any print statements or unnecessary comments?
• Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

[ctrlaltf24]

Style checks fail on existing code.
Compile check failed on socket2 (not even in the influxdb codebase). Perhaps the runner needs to update to latest rust (rust-lang/rust#49146 (comment)) ?

[ctrlaltf24]

@Empty2k12 thoughts?

[msrd0]

Thanks for your PR!

Please merge/rebase main. The compilation failure should go away. Also, #92 has been merged.

[ctrlaltf24]

Exposed under the "surf" feature. Do you prefer a separate function with_http_client (as is), or a separate new new_with_http_client?

[msrd0]

I think I prefer the former. Is there a reason why we don't make a client-agnostic Client::with_http_client(c: HttpClient) that just replaces self.client directly?

[ctrlaltf24]

I think I prefer the former. Is there a reason why we don't make a client-agnostic Client::with_http_client(c: HttpClient) that just replaces self.client directly?

Fair point! Updated to match.

[Empty2k12]

@msrd0 can this be merged?

[msrd0]

@Empty2k12 I was hoping for the CI to run first. No idea why it doesnt, I contacted GitHub Support on Monday asking why they've disabled actions on this repo.