feat(processing_engine): Add REST API endpoints for activating and deactivating triggers. #25711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonrnewhouse
force-pushed
the
processing_engine/activate_deactivate_delete
branch
from
11b3d8e to
c1b0b4c
Compare
pauldix
approved these changes
Dec 27, 2024
influxdb3_wal/src/lib.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize, Eq, PartialEq, Clone)] | ||
| pub struct DeletePlugin { |
There was a problem hiding this comment.
is this one needed with DeletePluginDefinition already defined?
There was a problem hiding this comment.
No, I'll delete it.
| let mut senders = self.plugin_event_tx.lock().await; | ||
|
|
||
| // TODO: should we be checking for replacements? | ||
| let (plugin_tx, plugin_rx) = mpsc::channel(4); |
There was a problem hiding this comment.
There shouldn't be that many messages in it, as right now there will only be one message per WAL file, wanted to leave a bit of room for cancel signals and backing up.
…activating triggers. Support deleting plugins.
jacksonrnewhouse
force-pushed
the
processing_engine/activate_deactivate_delete
branch
from
2a1ba80 to
5d5dc3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added support for deleting plugins. In particular, a plugin can't be deleted if it is associated with a trigger. I plan on adding deletes for triggers shortly.
In order to do this I needed to use a separate channel per trigger, rather than them all looking at a broadcast channel. This in turn caused
notify()to need to be async. This should be fine as notify_and_snapshot() already was.Tests should pass both with and without the system-py feature.