-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modify optimized compaction to cover edge cases #25594
Open
devanbenz
wants to merge
23
commits into
master-1.x
Choose a base branch
from
db/4201/compaction-bugs
base: master-1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d631314
feat: Modify optimized compaction to cover edge cases
devanbenz 67849ae
feat: Modify the PR to include optimized compaction
devanbenz 827e859
feat: Use named variables for PlanOptimize
devanbenz 5387ca3
feat: adjust test comments
devanbenz 3153596
feat: code removal from debugging
devanbenz 83d28ec
feat: setting BlockCount idx value to 1
devanbenz f896a01
feat: Adjust testing and add sprintf for magic vars
devanbenz f15d9be
feat: need to use int64 instead of int
devanbenz 54c8e1c
feat: touch
devanbenz 403d888
feat: Adjust tests to include lower level planning function calls
devanbenz 23d12e1
feat: Fix up some tests that I forgot to adjust
devanbenz d3afb03
feat: fix typo
devanbenz cf657a8
feat: touch
devanbenz fc6ca13
feat: Call SingleGenerationReason() once by initializing a
devanbenz 4fc4d55
feat: clarify file counts for reason we are not fully compacted
devanbenz c93bdfb
feat: grammar typo
devanbenz 2dd5ef4
feat: missed a test when updating the variable! whoops!
devanbenz 479de96
feat: Add test for another edge case found;
devanbenz c392906
feat: Remove some overlapping tests
devanbenz f444518
feat: Adds check for block counts and adjusts tests to use require.Ze…
devanbenz 5e4e2da
feat: Adds test for planning lower level TSMs with block sizes at agg…
devanbenz c315b1f
chore: rerun ci
devanbenz eb0a77d
feat: Add a mock backfill test with mixed generations, mixed levels, …
devanbenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!