Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue/806: Add a lock to prevent the disposal of the timer while it is running. #807

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OrezzerO
Copy link

@OrezzerO OrezzerO commented Jan 13, 2025

  • fix: Issue/806

Closes #806 806

Proposed Changes

Add a lock to prevent the disposal of the timer while it is running.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

* fix: Issue/806
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.50%. Comparing base (d641b11) to head (e2bdf03).

Files with missing lines Patch % Lines
...nternal/flowable/FlowableBufferTimedFlushable.java 77.77% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #807      +/-   ##
============================================
- Coverage     88.50%   88.50%   -0.01%     
+ Complexity      787      785       -2     
============================================
  Files           174      174              
  Lines          7203     7210       +7     
  Branches        405      407       +2     
============================================
+ Hits           6375     6381       +6     
  Misses          697      697              
- Partials        131      132       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OrezzerO OrezzerO changed the title fix: Issue/806: Add a lock to prevent the disposal of the timer while it is running. fix: Issue/806: Add a lock to prevent the disposal of the timer while it is running. <WIP> Jan 15, 2025
* docs: update CHANGELOG.md
@OrezzerO OrezzerO changed the title fix: Issue/806: Add a lock to prevent the disposal of the timer while it is running. <WIP> fix: Issue/806: Add a lock to prevent the disposal of the timer while it is running. Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timer task is disposed due to restartTimerOnMaxSize leading to data loss
2 participants