fix: Err should not be a dict in Python
#115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out `#[derive(IntoPyObject)]` for structs just creates a `dict`, which is not what we want.
crepererum
force-pushed
the
crepererum/err-wrapper-no-dict
branch
from
b81df16 to
c464190
Compare
Sl1mb0
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
#[derive(IntoPyObject)]for structs just creates adict, which is not what we want. For the happy path that we tested so far, this doesn't make a difference, but in #112 I'm gonna test the error case (e.g. for rejected/blocked requests) and there the Python error interface actually matters. In fact without this change,urllib3trips over this withAttributeError: 'dict' object has no attribute 'value'. Did you mean: 'values'?.