fix: queue offset before consumer #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an offset management issue in the bulk indexing worker by ensuring the offset is set to ctx1.NextOffset before submitting bulk requests, rather than using the obsolete pop.NextOffset value from individual messages.
Key Changes
- Updated offset assignment timing to use
ctx1.NextOffsetbefore bulk request submission in two locations - Removed the obsolete assignment of
offset = &pop.NextOffsetafter successful submission
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| committedOffset = offset | ||
| } else { | ||
| log.Error("offset not committed:", offset, ",moved to:", &pop.NextOffset) |
There was a problem hiding this comment.
The variable pop is undefined at this location. This line is inside the successful submission block (line 950-964), but the loop variable pop from line 831 is not accessible here. This will cause a compilation error. Consider either removing this log line or replacing &pop.NextOffset with &ctx1.NextOffset.
Suggested change
| log.Error("offset not committed:", offset, ",moved to:", &pop.NextOffset) | |
| log.Error("offset not committed:", offset, ",moved to:", &ctx1.NextOffset) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Rationale for this change
Standards checklist