chore: enhance bulk indexing - stricter offset validation and improved error handling #224
+112
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request introduces improved error handling and stricter validation for bulk request submissions in the Elasticsearch bulk indexing logic. The main focus is to ensure that bulk requests are only submitted when the offsets are valid and to provide clearer logging and error reporting when unexpected conditions occur.
Key changes include:
Bulk Request Submission Validation:
offset
andcommittedOffset
are non-nil and not equal, preventing unnecessary or duplicate submissions. If this condition is not met, an error is logged indicating that the request should not have been submitted. [1] [2] [3] [4]Error Handling and Logging Enhancements:
Response Handling in Core Bulk Processor:
core/elastic/bulk_processor.go
to return a more descriptive error if the server response is empty, and removed redundant code that previously handled this case. [1] [2]Rationale for this change
Standards checklist