feat: add search filter by ayangweb · Pull Request #1014 · infinilabs/coco-app

ayangweb · 2025-12-18T07:41:40Z

What does this PR do

Rationale for this change

Standards checklist

The PR title is descriptive
The commit messages are semantic
Necessary tests are added
Updated the release notes
Necessary documents have been added if this is a new feature
Performance tests checked, no obvious performance degradation

…to add-search-filter

Copilot

Pull request overview

This PR adds comprehensive search filtering functionality including fuzzy matching, date range filters, and aggregation-based filtering capabilities. The implementation spans both frontend (TypeScript/React) and backend (Rust) components.

Introduces fuzzy search with configurable fuzziness levels (0-5)
Adds date range filtering for update times with preset options (7 days, 90 days, 1 year) and custom range selection
Implements aggregation-based filtering for categories, languages, source IDs, and types
Updates UI components to support the new filtering features

Reviewed changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated 26 comments.

Show a summary per file

File	Description
src/types/search.ts	Added TypeScript interfaces for Aggregation, Aggregations, and updated MultiSourceQueryResponse to include aggregations field
src/stores/searchStore.ts	Extended search store with fuzzy match settings, date range filter, aggregate filter, and aggregations state management
src/pages/settings/shadcn-demo.tsx	Removed demo file (cleanup)
src/locales/zh/translation.json	Added Chinese translations for fuzzy match and filter UI elements
src/locales/en/translation.json	Added English translations for fuzzy match and filter UI elements
src/hooks/useSearch.ts	Enhanced search hook to include fuzziness, date range, and aggregate filter parameters in queries; added aggregation response handling
src/components/ui/slider.tsx	Extended Slider component to accept custom classNames for range and thumb elements
src/components/ui/multi-select.tsx	Complete rewrite using DropdownMenu instead of Popover for better UX and visual consistency
src/components/ui/date-picker-range.tsx	New component for date range selection using react-day-picker
src/components/ui/calendar.tsx	New calendar component with extensive customization options
src/components/Search/TimeFilter.tsx	New component providing comprehensive time-based and aggregation filtering UI
src/components/Search/InputControls.tsx	Integrated fuzzy match toggle with slider and TimeFilter component
src/components/Search/ExtensionStore.tsx	Minor style update (size-[20px] to size-5)
src/components/Search/AiOverview.tsx	UI consistency improvements using Button component
src/components/Cloud/UserProfile.tsx	UI consistency improvements using Button component
src-tauri/src/server/search.rs	Added query string conversion logic for filters and aggregation request body
src-tauri/src/search/mod.rs	Implemented aggregation merging logic and cleanup for multi-source queries
src-tauri/src/extension/third_party/mod.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/extension/third_party/install/store.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/extension/built_in/window_management/search_source.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/extension/built_in/file_search/mod.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/extension/built_in/calculator.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/extension/built_in/application/without_feature.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/extension/built_in/application/with_feature.rs	Updated to include aggregations field (None for local sources)
src-tauri/src/common/search.rs	Added Aggregation, AggBucket types with custom deserialization and merge_aggregations function with tests
pnpm-lock.yaml	Updated lucide-react dependency and added react-day-picker with date-fns dependencies
package.json	Updated lucide-react to 0.561.0 and added react-day-picker 9.13.0 and date-fns 4.1.0

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

src-tauri/src/search/mod.rs:61

Debug println! statements should be removed before merging to production. Consider using proper logging with appropriate log levels if this debugging information is needed.

    if query_strings.contains_key("datasource") && !query_strings.contains_key("querysource") {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-23T01:31:33Z

src/hooks/useSearch.ts

+          setAggregations(sortedAggregations);
+        } else {
+          setAggregations(void 0);
+          setAggregateFilter(void 0);


Using "void 0" instead of "undefined" is unconventional in TypeScript/JavaScript. While technically equivalent, "undefined" is more readable and idiomatic. Consider using "undefined" directly for better code clarity.

Copilot · 2025-12-23T01:31:34Z

src/components/ui/multi-select.tsx

  );
 };

+export default MultiSelect;


The component is exported both as a default export (line 115) and implicitly through the const declaration. For consistency and to avoid confusion, consider using only the default export pattern or documenting why both patterns are used.

Copilot · 2025-12-23T01:31:34Z

src/stores/searchStore.ts

      name: "search-store",
      partialize: (state) => ({
        sourceData: state.sourceData,
+        fuzziness: state.fuzziness,


The partialize function only persists 'sourceData' and 'fuzziness', but doesn't persist 'enabledFuzzyMatch'. This could lead to inconsistent state where the fuzziness value is persisted but the enabled state is not, potentially confusing users on page reload. Consider also persisting 'enabledFuzzyMatch' for a better user experience.

Suggested change

fuzziness: state.fuzziness,

fuzziness: state.fuzziness,

enabledFuzzyMatch: state.enabledFuzzyMatch,

Copilot · 2025-12-23T01:31:34Z

src/hooks/useSearch.ts

      }

-      //console.log("_suggest", searchInput, response);
+      console.log("_suggest", searchInput, response);


Console.log statements should be removed before merging to production. Debug logging should use proper logging mechanisms instead of console.log.

Copilot · 2025-12-23T01:31:34Z

src/components/Search/TimeFilter.tsx

+                setFilterDateRange(void 0);
+
+                setAggregateFilter(void 0);


Using "void 0" instead of "undefined" is unconventional in TypeScript/JavaScript. While technically equivalent, "undefined" is more readable and idiomatic. Consider using "undefined" directly for better code clarity.

Suggested change

setFilterDateRange(void 0);

setAggregateFilter(void 0);

setFilterDateRange(undefined);

setAggregateFilter(undefined);

Copilot · 2025-12-23T01:31:38Z

src-tauri/src/common/search.rs


+#[derive(Debug, Deserialize, Serialize, Clone)]
+pub struct Aggregation {
+    // Frontend code needs to this to not be NULL, so we `clean_aggregations()`


The comment states "Frontend code needs to this to not be NULL" which appears to have a grammatical error. It should be "Frontend code needs this to not be NULL" or "Frontend code requires this to not be NULL".

Suggested change

// Frontend code needs to this to not be NULL, so we `clean_aggregations()`

// Frontend code needs this to not be NULL, so we `clean_aggregations()`

Copilot · 2025-12-23T01:31:38Z

src/locales/zh/translation.json

+    "filers": {
+      "allTime": "全部时间",
+      "past7Days": "过去 7 天",
+      "past90Days": "过去 90 天",
+      "past1year": "过去 1 年",
+      "more": "更多",
+      "updateTime": "更新时间",
+      "selectDateRange": "选择日期范围",


The translation key is misspelled as "filers" instead of "filters". This inconsistency appears in both English and Chinese translation files and should be corrected to "filters" throughout.

Suggested change

"filers": {

"allTime": "全部时间",

"past7Days": "过去 7 天",

"past90Days": "过去 90 天",

"past1year": "过去 1 年",

"more": "更多",

"updateTime": "更新时间",

"selectDateRange": "选择日期范围",

"filters": {

"allTime": "全部时间",

"past7Days": "过去 7 天",

"past90Days": "过去 90 天",

"past1year": "过去 1 年",

"more": "更多",

"updateTime": "更新时间",

"selectDateRange": "选择日期范围",

Copilot · 2025-12-23T01:31:39Z

src/hooks/useSearch.ts

+        console.log("queryStrings", queryStrings);
+


Console.log statements should be removed before merging to production. Debug logging should use proper logging mechanisms instead of console.log.

Suggested change

console.log("queryStrings", queryStrings);

Copilot · 2025-12-23T01:31:39Z

src/components/ui/date-picker-range.tsx

+  return (
+    <Popover>
+      <PopoverTrigger asChild>
+        <div className="h-8 flex items-center justify-between px-2 border border-border rounded-lg">
+          {selected ? (
+            <div className="flex items-center gap-2">
+              <span>{dayjs(selected.from).format("YYYY-MM-DD")}</span>
+              <span className="text-muted-foreground">-</span>
+              <span>{dayjs(selected.to).format("YYYY-MM-DD")}</span>


The component doesn't handle the case where only one of 'from' or 'to' is set. When 'selected.to' is undefined, calling dayjs(undefined).format() will return "Invalid Date". Add a check to ensure both from and to exist before rendering, or handle partial date ranges appropriately.

Suggested change

return (

<Popover>

<PopoverTrigger asChild>

<div className="h-8 flex items-center justify-between px-2 border border-border rounded-lg">

{selected ? (

<div className="flex items-center gap-2">

<span>{dayjs(selected.from).format("YYYY-MM-DD")}</span>

<span className="text-muted-foreground">-</span>

<span>{dayjs(selected.to).format("YYYY-MM-DD")}</span>

const hasFrom = !!selected?.from;

const hasTo = !!selected?.to;

const hasAnyDate = hasFrom || hasTo;

return (

<Popover>

<PopoverTrigger asChild>

<div className="h-8 flex items-center justify-between px-2 border border-border rounded-lg">

{hasAnyDate ? (

<div className="flex items-center gap-2">

{hasFrom && (

<span>{dayjs(selected!.from).format("YYYY-MM-DD")}</span>

)}

{hasFrom && hasTo && (

<span className="text-muted-foreground">-</span>

)}

{hasTo && (

<span>{dayjs(selected!.to).format("YYYY-MM-DD")}</span>

)}

Copilot · 2025-12-23T01:31:39Z

src/components/Search/TimeFilter.tsx

+      {
+        key: "all-time",
+        label: t("search.filers.allTime"),
+        value: void 0,


Using "void 0" instead of "undefined" is unconventional in TypeScript/JavaScript. While technically equivalent, "undefined" is more readable and idiomatic. Consider using "undefined" directly for better code clarity.

Suggested change

value: void 0,

value: undefined,

ayangweb marked this pull request as draft December 18, 2025 07:41

feat: add search filter

ca350df

SteveLauC force-pushed the add-search-filter branch from 0f8656c to ca350df Compare December 18, 2025 07:55

ayangweb and others added 27 commits December 18, 2025 15:59

refactor: update

8d6204a

debugging: print query strings

530502e

refactor: update

494be3d

refactor: update

23607e6

refactor: update

5df1f96

refactor: update

fdc8967

refactor: update

eea6a7a

update

a8a14ca

update

724db0f

update

4c4c08a

style: remove unless file

0bcb974

update

ed10be5

update

28cf5ca

pass v2=true to coco server

371f8d0

print response body string

1ceb385

pass request body

1bb2d8b

chore: up

a339dba

Merge branch 'add-search-filter' of github.com:infinilabs/coco-app in…

b20cc77

…to add-search-filter

refactor: update

53f6b33

refactor: update

8a2898b

refactor: update

2235bd1

refactor: update

c698b40

refactor: update

78ec083

refactor: update

5e103bf

refactor: update

e89cca1

Bucket.label

fbbc5f1

refactor: update

93da466

ayangweb and others added 6 commits December 19, 2025 18:21

refactor: update

a488b0b

refactor: update

6ab9340

docs: document supported query strings

730a3b9

refactor: update

1e7247b

refactor: update

71ce892

refactor: update

33c68d9

ayangweb force-pushed the add-search-filter branch from e75a21e to 33c68d9 Compare December 22, 2025 08:06

refactor: update

af6a2c7

SteveLauC requested a review from Copilot December 23, 2025 01:26

Copilot started reviewing on behalf of SteveLauC December 23, 2025 01:26 View session

remove debugging printlns

a15f92b

Copilot AI reviewed Dec 23, 2025

View reviewed changes

SteveLauC added 3 commits December 23, 2025 09:38

move clean_aggregations() to common/search.rs

b84e45d

fix import

de4b009

typo filer->filter

a808b98

SteveLauC marked this pull request as ready for review December 23, 2025 01:52

ayangweb and others added 9 commits December 23, 2025 10:17

refactor: update

f236049

refactor: update

8735eb4

refactor: update

70bd96a

refactor: update

1fb6c65

refactor: update

9a6a466

refactor: update

7b0c961

refactor: update

4e6ccd2

refactor: update

be54c88

update

4d305f8

SteveLauC approved these changes Dec 24, 2025

View reviewed changes

update filter=updated filter=created format

e04ec1e

medcl approved these changes Dec 25, 2025

View reviewed changes

medcl merged commit 9135727 into main Dec 25, 2025
7 checks passed

medcl deleted the add-search-filter branch December 25, 2025 06:04

	fuzziness: state.fuzziness,
	fuzziness: state.fuzziness,
	enabledFuzzyMatch: state.enabledFuzzyMatch,

	// Frontend code needs to this to not be NULL, so we `clean_aggregations()`
	// Frontend code needs this to not be NULL, so we `clean_aggregations()`

Conversation

ayangweb commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do

Rationale for this change

Standards checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

SteveLauC Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

SteveLauC Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ayangweb commented Dec 18, 2025 •

edited

Loading