Skip to content

Conversation

@edenreich
Copy link
Contributor

Fixes #83

This PR addresses the security vulnerability where generated Dockerfiles were running containers as root user.

Changes

  • Added a2a group creation (GID 1001) and agent user (UID 1001)
  • Updated Go Dockerfile template to implement proper user management
  • Standardized Rust Dockerfile to use consistent a2a/agent naming
  • Ensured proper ownership and user switching for security

Security Benefits

  • Containers now run as non-privileged user instead of root
  • Follows container security best practices
  • Meets all acceptance criteria specified in the issue

Testing

  • All existing tests pass (✅ 18/18)
  • Generated sample projects verified for both Go and Rust
  • Code formatting and linting validation successful

Generated with Claude Code

claude bot and others added 5 commits October 5, 2025 15:53
- Create a2a group (GID 1001) and agent user (UID 1001)
- Switch containers to run as agent user instead of root
- Update Go Dockerfile to include proper user management
- Standardize Rust Dockerfile to use a2a/agent naming convention
- Ensure proper ownership of application directory

Fixes security vulnerability where containers ran as root user.
All acceptance criteria met for improved container security.

Co-authored-by: Eden Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Refactor the generated Dockerfile to be more secure

2 participants