Fix prefetch missing cacheFor default value #2136
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix prefetch method signature to match documentation
Description
Updates the
prefetch
method signature inrouter.ts
to match the documented behavior by providing a default value for thecacheFor
option. This fixes TS errors when callingrouter.prefetch
with two arguments and aligns with the documented API.Recreate
Calling
router.prefetch
to programmatically prefetch data like so:Results in
TS2554: Expected 3 arguments, but got 2.
andUncaught TypeError: Cannot destructure property 'cacheFor' of 'undefined' as it is undefined.
on runtime. This a result of not having a default value on theprefetch
method on the router.Changes
Related Documentation
https://inertiajs.com/prefetching#programmatic-prefetching
Thanks for such a great work on v2 🔥!