Play/Pause + small performance improvement #5
Conversation
|
Thanks for PR. Looks technically correct in every point. But to be honest, I don´t see a use case for play/pause. For me an animated background like this is "fire and forget" with no need for an API surface. But to respect your affort I´m willing to merge this PR if you have the need for it. Do you? |
|
Thank you. I do. Zodiac will be used in webkit-material-greeter2 that is close to completion. I previously used particleground but came across your pull request which claimed better performance. I need the ability to destroy the background because users are able to switch between several different background engines on the fly. |
|
Oh I´m no longer sure this has a better performance. I have seen some Performance problems while scrolling on https://stats.js.org/ and https://news.js.org/. Thats the reason why use images there. I have just seen that you where editing the JS file directly. Could you make the changes in the Typescript file and generate the JS (+ min) files from it? |
|
I don't know typescript and I don't have a the compiler either. And I don't want to do either of those things :P sry. |
|
I'm quite busy in the moment and don't find the time to port this to typescript. Maybe you have to work with your fork for some time... |
|
I completely understand. I will be working with my fork for the time being. Let me know if there is anything I can do to help. |
Let me know if you have any questions.