Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack around nameless isl Set equality in implemented-domain caching #768

Merged
merged 2 commits into from
May 10, 2023

Conversation

inducer
Copy link
Owner

@inducer inducer commented May 10, 2023

cc @isuruf

@inducer inducer force-pushed the hack-around-impl-domain-set-cache-aliasing branch from 0b71518 to ba3d5cf Compare May 10, 2023 01:27
@inducer inducer requested a review from kaushikcfd May 10, 2023 01:28
@inducer
Copy link
Owner Author

inducer commented May 10, 2023

This is gross, but it beats #736 as a way to enable a bunch of @isuruf's work to be merged into sumpy, IMO.

isuruf added a commit to isuruf/sumpy that referenced this pull request May 10, 2023
@inducer
Copy link
Owner Author

inducer commented May 10, 2023

Filed #769 as a reminder to back this out as soon as possible.

@inducer inducer merged commit f81c8fa into main May 10, 2023
@inducer inducer deleted the hack-around-impl-domain-set-cache-aliasing branch May 10, 2023 15:55
@inducer inducer removed the request for review from kaushikcfd May 10, 2023 15:55
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this LGTM as well. (Sorry for the late reply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants