Fix/unfollow button #519#532
Merged
indresh404 merged 3 commits intoJun 15, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
indresh404
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template 🚀
Description
Fixes the unfollow button not working on the Friends page. The previous implementation used a single atomic
writeBatchcontaining both the follow/unfollow document write and a distributed shard counter update for global stats. If the shard counter write failed (e.g. due to Firestore security rules restricting writes to theaggregatescollection), the entire batch failed atomically — silently blocking the actual follow/unfollow action too, with the error only logged to the console.This PR splits the two operations: the core follow/unfollow document write (delete on unfollow, set on follow) now happens independently and must succeed for the button to work. The shard counter update is now best-effort and non-blocking — its failure no longer prevents follow/unfollow from working.
Related Issue
Closes #519
Type of Change
Screenshots / Videos (if applicable)
Testing Done
npm run testnpm run lintnpm run buildhttp://localhost:5173)Steps to reproduce/verify:
Checklist
Contributor Declaration