fix: respect persisted sidebar collapse preference on resize for desktop widths#528
Merged
indresh404 merged 1 commit intoJun 15, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
bug
indresh404
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496
Problem:
useSidebar initializes isCollapsed from localStorage ("sidebar_collapsed"), but a resize effect ran handleResize() immediately on mount and on every resize, unconditionally setting isCollapsed to false for widths >= 1024px — overriding the user's saved preference every time.
Fix:
Removed the unconditional "else { setIsCollapsed(false) }" branch. Narrow screens (<1024px) still force-collapse the sidebar for responsiveness, but desktop widths no longer reset isCollapsed, so the localStorage-restored value (or the user's manual toggle) persists correctly.
Files changed:
Testing: