Skip to content

Fix: College input validation bypass via state mismatch (Issue #264) #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adi-Marathe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: College input validation bypass via state mismatch (Issue #264) #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/Onboarding.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ export const Onboarding = () => {
setIsLoading(false);
return;
}
if (!selectedCollege || !collegesList.includes(selectedCollege)) {
setError("Please select a college from the searchable dropdown list.");
if (!selectedCollege || !collegesList.includes(selectedCollege) || collegeSearch !== selectedCollege) {
setError("Please select a valid college from the searchable dropdown list.");
setIsLoading(false);
return;
}
Expand Down