Fix: Prevent invalid manual entries in college input (#210)#325
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
bug
Owner
|
Fix conflict |
Contributor
Author
|
Hello @indresh404 |
Owner
|
If your PR still shows the old failed Vercel check, please rebase (or merge the latest main branch into your branch) and push again to trigger a fresh deployment/check run. |
Adi-Marathe
force-pushed
the
fix-issue-210
branch
from
b06e427 to
e583fb3
Compare
Contributor
Author
|
Hello @indresh404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent invalid manual entries in college input
Closes #210
Description
This PR resolves an issue in the onboarding form where users could bypass validation and submit invalid manual entries for their college.
Previously, the form only validated the underlying
selectedCollegestate. If a user first clicked a valid college from the dropdown, but later typed an invalid entry in the input box, the form would pass validation using the oldselectedCollegevalue and submit it. This created a discrepancy between what the user saw (their invalid entry) and what was actually submitted.Changes Made
src/pages/Onboarding.jsxto ensure that the current search text (collegeSearch) strictly matches the internally trackedselectedCollege.selectedCollege !== collegeSearchcondition to correctly block the submission and alert the user when they have typed an unselected value.Proof of Fix
RankerHub.Gamified.Developer.Leaderboard.mp4