Fix: Resolve Dual GitHub Token Storage Failures (Fixes #263)#324
Open
Adi-Marathe wants to merge 1 commit into
Open
Fix: Resolve Dual GitHub Token Storage Failures (Fixes #263)#324Adi-Marathe wants to merge 1 commit into
Adi-Marathe wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves Issue #263, where storing GitHub access tokens in two different
sessionStoragekeys (gh_access_tokenandgh_token_${uid}) resulted in severe synchronization issues, silent API failures, and misleading "rate limit" errors.Changes Made
Centralized Token Management:
src/utils/tokenManager.js.store(),get(),remove(), andclear()methods, all using a single key format:gh_token_${uid}.Cleaned up
AuthContext.jsx:gh_access_token.sessionStorageAPI calls inloginandlogoutfunctions withTokenManager.Fixed Missing Token Handling in
GitRank.jsx:sessionStorage.getItemlookup withTokenManager.get(user?.uid).Proof of Fix
grep) forgh_access_tokenand verified 0 occurrences remain in the codebase.gh_token_is now completely isolated withintokenManager.js.npm run build) was successfully compiled without any errors.Acceptance Criteria Verified
gh_access_tokenkey entirely.TokenManagerutility.Closes: #263