Skip to content

fix: remove hardcoded mock follower IDs from Friends page (#186)#257

Open
5hivam123 wants to merge 1 commit into
indresh404:mainfrom
5hivam123:fix/remove-mock-follower-ids-friends
Open

fix: remove hardcoded mock follower IDs from Friends page (#186)#257
5hivam123 wants to merge 1 commit into
indresh404:mainfrom
5hivam123:fix/remove-mock-follower-ids-friends

Conversation

@5hivam123
Copy link
Copy Markdown
Contributor

Description

Removed hardcoded mock follower IDs that were causing every user
to see 2 fake followers regardless of their actual follower data.

Related Issue

Fixes #186

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots / Videos (if applicable)

[Add screenshot of Friends page Followers tab showing empty state]

Testing Done

  • Visual verification on local dev server (http://localhost:5173)
  • Followers tab now shows empty state for new users ✅
  • No fake mock followers appear ✅
  • No console errors or warnings

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings or console errors.

Contributor Declaration

  • I confirm that this contribution is made under the rules of NSoC 2026.
  • I confirm that I have been assigned the related issue by a maintainer before opening this PR.
  • I have read the Contributing Guidelines and Code of Conduct.

@5hivam123 5hivam123 requested a review from indresh404 as a code owner June 3, 2026 13:20
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ranker-hub Ready Ready Preview, Comment Jun 3, 2026 1:20pm

@github-actions github-actions Bot added backend Backend/Firebase related changes bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request frontend Frontend related changes (HTML/CSS/JS/React) labels Jun 3, 2026
@github-actions github-actions Bot added gssoc GirlScript Summer of Code gssoc26 GirlScript Summer of Code 2026 nsoc NSoC NSoC'26 NSoC 2026 pending-review PR is pending review labels Jun 3, 2026
@5hivam123
Copy link
Copy Markdown
Contributor Author

Hi @indresh404! 👋

I've fixed this issue.

Changes made in src/pages/Friends.jsx:

  • Removed hardcoded mock follower block (~line 47)
  • Followers tab now shows real data or empty state

PR: [paste your PR link here]

Please review when you get a chance. Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend/Firebase related changes bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request frontend Frontend related changes (HTML/CSS/JS/React) gssoc GirlScript Summer of Code gssoc26 GirlScript Summer of Code 2026 level:intermediate level2 nsoc NSoC NSoC'26 NSoC 2026 pending-review PR is pending review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Bug]: Hardcoded mock follower IDs in Friends page should be removed

2 participants