Hotfixes: fix check_value() error messaging + remove duplicate receiver_ids + write_dwc(rights_holder = NULL) sql bug
#357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietrH
added a commit
to inbo/etnservice
that referenced
this pull request
Apr 22, 2025
4 tasks
|
Found bug : #358 |
PietrH
changed the title
check_value() error messagingcheck_value() error messaging + remove duplicate receiver_ids`
PietrH
changed the title
check_value() error messaging + remove duplicate receiver_ids`check_value() error messaging + remove duplicate receiver_ids + write_dwc(rights_holder = NULL)` sql bug
PietrH
changed the title
check_value() error messaging + remove duplicate receiver_ids + write_dwc(rights_holder = NULL)` sql bugcheck_value() error messaging + remove duplicate receiver_ids + write_dwc(rights_holder = NULL) sql bug
peterdesmet
approved these changes
Apr 22, 2025
| @@ -1,6 +1,6 @@ | |||
| Package: etn | |||
| Title: Access Data from the European Tracking Network | |||
| Version: 2.2.1 | |||
| Version: 2.2.2 | |||
There was a problem hiding this comment.
If you bump here, don't forget to bump in CITATION.cff before you release. Same with DOI in CITATION.cff, which is tricky, since you don't know it yet. I have no solution for this.
There was a problem hiding this comment.
I used the general, all version DOI in my citation.cff. Was that a mistake?
There was a problem hiding this comment.
Ah, didn't catch that. That works! 👍
There was a problem hiding this comment.
What about this action, if it triggers on release, do I still need to do anything?
https://github.com/inbo/etn/blob/main/.github/workflows/update-citation-cff.yaml
PietrH
deleted the
356-bug-check_value-is-unable-to-handle-na-in-reference-when-failing-assertion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfixes
AI Summary
Bug Fixes and Improvements:
check_value()where error messages failed to format correctly whenNAvalues were present in the reference list. The logic for removingNAvalues was corrected.list_receiver_ids()whereNAvalues were included in the results. The function now explicitly filters outNAvalues.write_dwc()where the function would fail ifrights_holderwas not provided. A default value ofNA_character_is now assigned whenrights_holderis missing.Test Enhancements:
check_value()to verify it handlesNAvalues in the reference list and produces appropriate error messages.list_receiver_ids()to ensure it returns a unique, non-NAcharacter vector and includes known values.write_dwc()to validate the behavior of therights_holderparameter, including cases where it is explicitly set or left as default.Documentation and Metadata:
2.2.2inDESCRIPTIONto reflect the new changes.NEWS.mdsummarizing the fixes and improvements in this release.