Skip to content

[ID-3557, ID-3579][DO NOT MERGE] feat: remove device code auth #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[ID-3557, ID-3579][DO NOT MERGE] feat: remove device code auth #487

wants to merge 9 commits into from

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jun 12, 2025

Summary

  • Removed Device Code authentication
  • Updated sample app to use only PKCE
  • Removed unit tests related to Device Code authentication
  • Refactored login and logout functions to remove PKCE suffix
  • Cleaned up variable names

Customer Impact

This is a breaking change. Device Code authentication has been removed in favour of PKCE, which is more secure. The LoginPKCE and LogoutPKCE methods have been removed; instead, Login and Logout now use PKCE internally.

Other things to consider:

  • Sample app is updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Sample game is updated with new SDK changes

@nattb8 nattb8 changed the title [ID-3557, ID-3579] feat: remove device code auth [ID-3557, ID-3579][DO NOT MERGE] feat: remove device code auth Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImmutableJeffrey ImmutableJeffrey ImmutableJeffrey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattb8 @ImmutableJeffrey