Skip to content

[DX-3550] refactor: marketplace package to use static functions for generating urls #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jan 28, 2025

Summary

  • Refactored the Marketplace package to align with the Unreal SDK. Replaced the class-based URL generation with static functions for on-ramp, swap, and bridge flows, simplifying the process for developers.
  • Updated the GitHub Action workflow to accurately copy sample scenes and scripts for the Passport and Marketplace packages.

Customer Impact

Simplifies the generation of on-ramp, swap, and bridge URLs by using static functions instead of requiring developers to create and use a separate class.

Other things to consider:

  • Sample app is updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Sample game is updated with new SDK changes

@nattb8 nattb8 requested a review from a team January 28, 2025 04:15
@nattb8 nattb8 merged commit f6fb5e4 into main Jan 28, 2025
18 checks passed
@nattb8 nattb8 deleted the refactor/marketplace branch January 28, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants