Skip to content

[SDX-3448] iOS browserstack tests on CICD #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 15, 2024

Conversation

andrew-yangy
Copy link
Collaborator

Summary

Customer Impact

Added

Changed

Deprecated

Removed

Fixed

Security

Things worth calling out

Other things to consider:

  • Sample app is updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Sample game is updated with new SDK changes
  • Replied to GitHub issues

@andrew-yangy andrew-yangy requested a review from a team November 12, 2024 00:28
@nattb8 nattb8 force-pushed the feature/dx-3448-ios-browserstack branch from 828fed9 to ff1c7f9 Compare November 14, 2024 09:12
@nattb8 nattb8 force-pushed the main branch 2 times, most recently from e7ec084 to f188bf6 Compare November 14, 2024 09:19
@@ -8,7 +8,7 @@

def get_mailslurp_client():
configuration = mailslurp_client.Configuration()
configuration.api_key['x-api-key'] = os.getenv('MAILSLURP_API_KEY')
configuration.api_key['x-api-key'] = '***REMOVED***' #os.getenv('MAILSLURP_API_KEY')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this anymore?

@andrew-yangy andrew-yangy merged commit b459f61 into main Nov 15, 2024
20 of 21 checks passed
@andrew-yangy andrew-yangy deleted the feature/dx-3448-ios-browserstack branch November 15, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants