Skip to content

[DX-2959] fix: throw an error if provider is not set #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jun 26, 2024

Summary

Resolved an issue where the SDK did not throw an error if the provider was not set when connecting to IMX and EVM. Also fixed other issues in the sample app.

Customer Impact

Resolved an issue where the SDK did not throw an error if the provider was not set when connecting to IMX and EVM. Customers should update to ensure proper connection handling.

Fixed

  • Sample app: clicking on 'Connect' button on the Authenticated Scene it should reconnect the user
  • Sample app: correct logout method should be used to match how the user logged in
  • Sample app: add try-catch around all SDK functions
  • Sample app: clear storage cache on Unauthenticated Scene should happen before printing the final output on screen

Others

  • Refactored BrowserCommuncationsManager handle result code
  • Updated game bridge code (built from ts-immutable-sdk version 1.44.1)

Other things to consider:

  • Sample app is updated with new SDK changes

@nattb8 nattb8 requested a review from a team June 26, 2024 07:36
@nattb8 nattb8 changed the title fix: throw an error if provider is not set [DX-2959] fix: throw an error if provider is not set Jun 27, 2024
@nattb8 nattb8 enabled auto-merge June 27, 2024 03:40
@nattb8 nattb8 merged commit bc53c76 into main Jun 27, 2024
15 checks passed
@nattb8 nattb8 deleted the fix/game-bridget-status-response branch June 27, 2024 03:54
@github-actions github-actions bot added the fix label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants