feat(checkout): Handle network switch when using walletconnect #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeetparikh
commented
Jun 5, 2025
| // walletconnect on trying to switch network, if network doesn't exist, it does not throw an error! | ||
| // so the catch block below is not triggered, so we need to add the network manually | ||
| // always calling addNetworkToWallet is harmless, as nothing happens if the network already exists | ||
| if (provider.ethereumProvider?.isWalletConnect) { |
There was a problem hiding this comment.
this is crucial for walletconnect switch to work. Also adds a new network prompt when you don't have the network added
|
View your CI Pipeline Execution ↗ for commit 11e7b27.
☁️ Nx Cloud last updated this comment at |
keithbro-imx
reviewed
Jun 6, 2025
| @@ -218,20 +218,14 @@ export function WalletList(props: WalletListProps) { | |||
| const browserProvider = new WrappedBrowserProvider(ethereumProvider); | |||
| selectBrowserProvider(browserProvider, 'walletconnect'); | |||
There was a problem hiding this comment.
Do we need to do this?
There was a problem hiding this comment.
Never mind, I see why we do
keithbro-imx
reviewed
Jun 6, 2025
| @@ -218,20 +218,14 @@ export function WalletList(props: WalletListProps) { | |||
| const browserProvider = new WrappedBrowserProvider(ethereumProvider); | |||
| selectBrowserProvider(browserProvider, 'walletconnect'); | |||
|
|
|||
| const { chainId } = await ((await browserProvider.getSigner()).provider.getNetwork()); | |||
|
|
|||
| if (ethereumProvider.chainId !== targetChainId) { | |||
There was a problem hiding this comment.
From my testing, the ethereumProvider.chainId was never targetChainId - even when my MM was on the right chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalletConnect switch wasn't working when on the wrong network. This now forces the 'Switch network' screen requiring user to interact in order to switch the network.