Fix simple strict provenance cases in analysis/test#699
Open
Fix simple strict provenance cases in analysis/test#699
analysis/test#699Conversation
kkysen
force-pushed
the
kkysen/analysis-test-strict-provenance
branch
from
77a8271 to
46eca71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #682.
More specifically, it fixes the low-hanging fruit of achieving strict provenance by replacing
0 as *{const,mut} _withstd::ptr::null{,_mut}(). The real int-to-ptr instances wherestd::ptr::from_exposed_addrandptr::expose_addr()should be used I've left as is, though, as 1) strict provenance is still unstable and 2) that's what we currently emit. But removing the0 as *{const,mut} _makes themirioutput much easier to deal with.