Skip to content

Introduce some snapshot tests of c2rust-transpile #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jameysharp
Copy link
Contributor

Here's a quick implementation of snapshot testing for c2rust-transpile. I'm open to bike-shedding, such as discussing how the test files are laid out, or any other requests. I thought I'd just put together a quick proof of concept to start discussion with.

@kkysen kkysen self-requested a review May 14, 2025 06:06
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great as a proof of concept. I do think we'd like to keep the existing tests and their structure, though, if you'd like to work on that. Also, sorry I took a little while to review this. It's very welcome.

@jameysharp
Copy link
Contributor Author

No worries! I have my own distractions to deal with anyway.

When you say you'd "like to keep the existing tests and their structure", what do you mean by that? I guess if you could lay out more concretely what kind of structure you have in mind for these tests, that would help me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants