WIP: Move from Azure Pipelines to GitHub Actions #1232
Conversation
joshtriplett
force-pushed
the
switch-to-github-actions
branch
2 times, most recently
from
ca30d92 to
a7bf658
Compare
|
@kkysen Would you mind safelisting |
joshtriplett
force-pushed
the
switch-to-github-actions
branch
4 times, most recently
from
6945fa0 to
1cd2856
Compare
Do you know how to do that? |
I believe it'll be in the GitHub actions settings, either for the project or for the organization. There's a setting for where it can run actions from. |
@thedataking, can you see if you're able to do this? I don't see where I can, or I probably don't have permission to do it. See the error message here: https://github.com/immunant/c2rust/actions/runs/14911291371. |
joshtriplett
force-pushed
the
switch-to-github-actions
branch
4 times, most recently
from
e0c2712 to
6dacb8c
Compare
| arch: | ||
| containerImage: immunant/c2rust:archlinux-base-latest | ||
| debian10: | ||
| containerImage: immunant/c2rust:debian-buster-latest | ||
| debian11: | ||
| containerImage: immunant/c2rust:debian-bullseye-latest | ||
| fedora34: | ||
| containerImage: immunant/c2rust:fedora-34-latest | ||
| ubuntu20: | ||
| containerImage: immunant/c2rust:ubuntu-focal-latest | ||
| ubuntu18: | ||
| containerImage: immunant/c2rust:ubuntu-bionic-latest |
There was a problem hiding this comment.
Can we test on all of these distros and versions in GitHub Actions, too, instead of just Ubuntu 24?
There was a problem hiding this comment.
Oh wait, GitHub Actions only supports Ubuntu, right? So we'll have to drop testing on all the others. @thedataking is this okay?
There was a problem hiding this comment.
@kkysen It's theoretically possible to run a custom container of an arbitrary distro on GitHub Actions, but one of the huge benefits of this change to the CI is avoiding the separate (and manual) step of building containers, which makes it impossible for contributors to modify and test (because contributors can't replace those containers). With the new approach, all the packages are installed on the fly, and it's much easier to iterate on the result.
I think that usability improvement would be worth making this change.
scripts/provision_mac.sh
Outdated
There was a problem hiding this comment.
Can we fully inline this in ci.yml? And the other provision scripts, too.
There was a problem hiding this comment.
I'd be happy to do that as an additional step, once this builds at all on macOS. Would you mind if that's a follow-up PR?
joshtriplett
force-pushed
the
switch-to-github-actions
branch
from
6dacb8c to
52a98eb
Compare
This simplifies the CI setup substantially. Fixes: immunant#1226
joshtriplett
force-pushed
the
switch-to-github-actions
branch
from
52a98eb to
71a8069
Compare
This simplifies the CI setup substantially.