Add support for foveateBoundTexture + small bikeshed nits#312
Merged
cabanier merged 3 commits intoimmersive-web:mainfrom Apr 4, 2025
Merged
Add support for foveateBoundTexture + small bikeshed nits#312cabanier merged 3 commits intoimmersive-web:mainfrom
cabanier merged 3 commits intoimmersive-web:mainfrom
Conversation
cabanier
force-pushed
the
foveateBoundTexture
branch
from
6900516 to
6cd417f
Compare
toji
reviewed
Apr 1, 2025
webxrlayers-1.bs
Outdated
| 1. If |fixed_foveation| is less than <code>0</code>, set it to <code>0</code>. | ||
| 1. If |fixed_foveation| is more than <code>1</code>, set it to <code>1</code>. | ||
| 1. If no texture is bound to |target| in |binding|'s [=XRWebGLBinding/context=], throw an {{InvalidStateError}} and abort these steps. | ||
| 1. Apply |fixed_foveation| to |target| using |binding|'s [=XRWebGLBinding/context=]. |
Member
There was a problem hiding this comment.
I feel like this step needs more detail, but you probably already knew that. :)
Specifically, we should be specifying the relationship between the float and how much foveation is applied (is 0 the highest quality or 1? Does setting the highest quality imply that foveation is removed?), make it clear what aspects of foveation are determined by the implementation, etc.
Member
Author
There was a problem hiding this comment.
Maybe I can refer to the WebXR spec's definition of fixedFoveation.
Member
There was a problem hiding this comment.
That would probably be sufficient, yeah.
cabanier
force-pushed
the
foveateBoundTexture
branch
from
ea8662f to
e6d212f
Compare
toji
approved these changes
Apr 4, 2025
Member
toji
left a comment
toji
left a comment
There was a problem hiding this comment.
LGTM, thanks for the updates! (And yeah, the target arg is necessary, thanks for catching that.)
github-actions bot
added a commit
that referenced
this pull request
Apr 4, 2025
SHA: 66f1173 Reason: push, by cabanier Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to cabanier/layers
that referenced
this pull request
Sep 10, 2025
SHA: 66f1173 Reason: push, by cabanier Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at adding support for foveateBoundTexture.
I still need to investigate how I can amend the spec to remove the foveation.
Preview | Diff