fix(cohttp): ensure response body is always consumed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to make it obvious that the body is consumed using `Util.consume_body` or `Util.drain_body` right next to the request call site.
mattjbray
force-pushed
the
matt/consume-body
branch
from
04a44e3 to
a0baf3e
Compare
mattjbray
commented
Aug 30, 2024
| Cohttp_lwt_unix.Client.get uri ~headers:metadata_headers | ||
| >>= Util.drain_body |
There was a problem hiding this comment.
This was previously being leaked.
| @@ -230,22 +233,20 @@ module External_account_credentials = struct | |||
| |> to_string | |||
|
|
|||
| let subject_token_of_response (t : t) | |||
| ((resp, body) : Cohttp.Response.t * Cohttp_lwt.Body.t) : | |||
| ((resp, body_str) : Cohttp.Response.t * string) : | |||
There was a problem hiding this comment.
Helper functions now take a string instead of the Cohttp_lwt.Body.t, to encourange consuming the body at the request call site.
sam-tombury
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to make it obvious that the body is consumed using
Util.consume_bodyorUtil.drain_bodyright next to the request call site.