Auto-gen to/from json via deriving yojson #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also not sure how appropriate the way I introduced the to/from functions are (by shadowing the original modules). Another idea to make things even simpler is to use Zarith and Ptime's to_string and from_string implementation. |
benbellick
commented
Aug 24, 2024
| @@ -1,5 +1,81 @@ | |||
| module Imandra_ptime = struct | |||
There was a problem hiding this comment.
Realizing now that I can make this even better with the usage of Imandra-codegen! Will give that a try later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the other PR, I wanted to see if I could get the to/from json functions auto generated via deriving yojson. This is just a pass I took which I haven't tested yet, but I wanted to get some feedback. If this seems more confusing, we can always just go back. Thanks! 😄