Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reorder services, fix permission issues (noml) #422

Open
wants to merge 3 commits into
base: noml
Choose a base branch
from
Open

fix: reorder services, fix permission issues (noml) #422

wants to merge 3 commits into from

Conversation

hydazz
Copy link
Member

@hydazz hydazz commented Jul 20, 2024

No description provided.

@ImageGeniusCI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/noml-v1.109.2-pkg-f8a22115-dev-fb8e61e98a56c771a8e0b525f97b38b69740a823-pr-422/index.html
https://ci-tests.imagegenius.io/immich/noml-v1.109.2-pkg-f8a22115-dev-fb8e61e98a56c771a8e0b525f97b38b69740a823-pr-422/shellcheck-result.xml

Tag Passed
amd64-noml-v1.109.2-pkg-f8a22115-dev-fb8e61e98a56c771a8e0b525f97b38b69740a823-pr-422 ✅
arm64v8-noml-v1.109.2-pkg-f8a22115-dev-fb8e61e98a56c771a8e0b525f97b38b69740a823-pr-422 ❌

@hydazz hydazz requested a review from martabal July 24, 2024 06:04
@ImageGeniusCI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/noml-v1.109.2-pkg-f8a22115-dev-de00fb8ea1ec40569aa197a3d1c6224d5d68d18a-pr-422/index.html
https://ci-tests.imagegenius.io/immich/noml-v1.109.2-pkg-f8a22115-dev-de00fb8ea1ec40569aa197a3d1c6224d5d68d18a-pr-422/shellcheck-result.xml

Tag Passed
amd64-noml-v1.109.2-pkg-f8a22115-dev-de00fb8ea1ec40569aa197a3d1c6224d5d68d18a-pr-422 ✅
arm64v8-noml-v1.109.2-pkg-f8a22115-dev-de00fb8ea1ec40569aa197a3d1c6224d5d68d18a-pr-422 ❌

martabal
martabal reviewed Jul 24, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@ImageGeniusCI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/noml-v1.112.1-pkg-f8a22115-dev-789f6b1f43fa87bf0e42e036037b2adaf001a43f-pr-422/index.html
https://ci-tests.imagegenius.io/immich/noml-v1.112.1-pkg-f8a22115-dev-789f6b1f43fa87bf0e42e036037b2adaf001a43f-pr-422/shellcheck-result.xml

Tag Passed
amd64-noml-v1.112.1-pkg-f8a22115-dev-789f6b1f43fa87bf0e42e036037b2adaf001a43f-pr-422 ✅
arm64v8-noml-v1.112.1-pkg-f8a22115-dev-789f6b1f43fa87bf0e42e036037b2adaf001a43f-pr-422 ❌

@hydazz hydazz requested a review from martabal September 23, 2024 22:33
martabal
martabal reviewed Sep 24, 2024
View reviewed changes
Dockerfile
@@ -13,9 +13,9 @@ LABEL maintainer="hydazz, martabal"
ENV \
IMMICH_BUILD_DATA="/app/immich/server" \
IMMICH_ENV="production" \
IMMICH_MACHINE_LEARNING_ENABLED="false" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to change the order and remove the quotes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martabal martabal martabal left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hydazz @ImageGeniusCI @martabal