Write ICC profiles to TIFF files #2746
Merged
+66
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and we've already done this change to JpegEncoder
…nction in preparation for the ICC writing logic
This was referenced Jan 28, 2026
197g
approved these changes
Jan 28, 2026
Member
Author
|
Wait, this seems to be missing Let me make it into a draft and double-check. |
Member
Author
|
Oh, I've accidentally used a TIFF file produced by imagemagick for testing instead of wondermagick. I've deleted it and re-tested with this branch, the ICC profile does correctly roundtrip through PNG->TIFF->PNG conversion and the resulting image looks the same as the starting PNG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually using Shnatsel/wondermagick#84 and the image from #1756
I've confirmed that the ICC profile written this way can be read back both by
imageand by imagemagick.