Improve BMP resumable decoder to resume on metadata #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anforowicz
reviewed
Jan 27, 2026
anforowicz
reviewed
Jan 27, 2026
197g
reviewed
Jan 28, 2026
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
Thanks @anforowicz for already doing a lot of that review. Manual state machines are hard to write and review, I'm not entirely sure I caught everything but there was some change in behavior. Maybe future Rust will give us better tools.
197g
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the coarse-grained resumable decoding from #2738 and its further extension to support resumable row decoding from #2744 to also support resuming during metadata parsing. Mainly 3 different stages are defined (headers parsing, palette and icc profile), so that if UnexpectedEof occurs during their parsing, the decoder can now be resumed from the last recoverable point from metadata rather than restarting from the beginning.
This PR should complete #2696 (considering that by now resuming RLE decompression is not resumable and each retry will require to be resumed from the beginning of image data)