refactor: centralize file size error message in upload_config (#635)#993
Open
Pranjalverma0720 wants to merge 1 commit into
Open
refactor: centralize file size error message in upload_config (#635)#993Pranjalverma0720 wants to merge 1 commit into
Pranjalverma0720 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #635 by refactoring the file size validation error handling. Instead of relying on a hardcoded string inside the upload router, it now utilizes the centralized
UPLOAD_ERROR_MESSAGESdictionary located in the configuration file.Changes Made
backend/app/utils/upload_config.py: Added a dedicated"file_too_large"key-value pair to theUPLOAD_ERROR_MESSAGESdictionary to explicitly communicate the 5MB size restriction.backend/app/routers/upload_file.py: ImportedUPLOAD_ERROR_MESSAGESand updated theHTTPExceptiondetail inside the file size validation block to reference the newly created config key.Related Issues
Closes #635