fix(security): enforce JWT_SECRET as required environment variable#957
Open
anshul23102 wants to merge 1 commit into
Open
fix(security): enforce JWT_SECRET as required environment variable#957anshul23102 wants to merge 1 commit into
anshul23102 wants to merge 1 commit into
Conversation
- Add _required_env() helper function to enforce mandatory configuration - Update jwt_secret to use _required_env() instead of fallback to default - Application now fails fast at startup if JWT_SECRET is not set - Prevents token forgery attacks from known default secrets Closes imDarshanGK#707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the critical JWT secret vulnerability by enforcing JWT_SECRET as a required environment variable. The application now fails fast at startup if JWT_SECRET is not configured, preventing token forgery attacks.
Problem
The backend/app/config.py uses a hardcoded fallback secret when JWT_SECRET environment variable is not set:
This well-known default secret can be exploited by attackers to forge valid JWT tokens for any user_id, gaining authenticated access to protected endpoints.
Solution
Changes
Security Impact
Testing
Related Issue
Closes #707
This contribution is part of GSSoC 2026. Please consider adding the gssoc-approved label when reviewed.