Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating critical packages; Setting up CI; Fixing for Web Components #8

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Updating critical packages; Setting up CI; Fixing for Web Components #8

merged 10 commits into from
Sep 13, 2024

Conversation

stevematney
Copy link
Collaborator

PR Requirements

  • The action code does not contain sensitive information.

stevematney and others added 7 commits September 11, 2024 16:23
@stevematney
docs(react): update text-mask/text-mask refs to im-open/text-mask
a8dbc4e
@dependabot @stevematney
Bump send and express
db6a776 
Bumps [send](https://github.com/pillarjs/send) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `send` from 0.16.2 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.16.2...0.19.0)

Updates `express` from 4.16.3 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.16.3...4.20.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@stevematney
build(core): getting react tests and website running with updated pac…
fca5631 
…kages
@stevematney
build(react): ensuring react passes all tests
17cd22e
@stevematney
refactor(core): conforming createTextMaskInputElement to eslint rules
c9e085f
@stevematney
fix(core): ensuring caret setting works with Web Components
3450dba
@stevematney
build(core): ensuring core, react, and website builds run
b1a7972
@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version for testing: 5.1.3-fix-web-components-7261976.1
You can test it by using:

npm install @im-open/react-text-mask@im-open/react-text-mask

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version for testing: 5.4.4-fix-web-components-7261976.1
You can test it by using:

npm install @im-open/react-text-mask@im-open/react-text-mask

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version for testing: 5.1.3-fix-web-components-d489cab.1
You can test it by using:

npm install @im-open/text-mask-core@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version for testing: 5.4.4-fix-web-components-d489cab.1
You can test it by using:

npm install @im-open/react-text-mask@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version on @im-open/text-mask-core for testing: 5.1.3-fix-web-components-261017e.1
You can test it by using:

npm install @im-open/text-mask-core@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version on @im-open/react-text-mask for testing: 5.4.4-fix-web-components-261017e.1
You can test it by using:

npm install @im-open/react-text-mask@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version on @im-open/text-mask-core for testing: 5.1.3-fix-web-components-06ca88e.1
You can test it by using:

npm install @im-open/text-mask-core@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version on @im-open/react-text-mask for testing: 5.4.4-fix-web-components-06ca88e.1
You can test it by using:

npm install @im-open/react-text-mask@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version on @im-open/text-mask-core for testing: 5.1.3-fix-web-components-64d0b9f.1
You can test it by using:

npm install @im-open/text-mask-core@fix-web-components

@im-pipeline-bot
Copy link
Collaborator

This PR is part of this prerelease version on @im-open/react-text-mask for testing: 5.4.4-fix-web-components-64d0b9f.1
You can test it by using:

npm install @im-open/react-text-mask@fix-web-components

stevematney
stevematney commented Sep 13, 2024
View reviewed changes
core/src/createTextMaskInputElement.js
}

function safeSetSelection(element, selectionPosition) {
if (document.activeElement === element) {
if (getActiveElement() === element) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.activeElement will return only the outer element of a Web Component. We have to dig all the way down to find the actual active element.

@stevematney
Copy link
Collaborator Author

Mario's review is valid. Going to bypass requirements and merge.

@stevematney stevematney merged commit 9f45b25 into main Sep 13, 2024
2 checks passed
@stevematney stevematney deleted the fix-web-components branch September 13, 2024 20:28
@im-pipeline-bot
Copy link
Collaborator

🎉 This PR is included in version 5.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@im-pipeline-bot
Copy link
Collaborator

🎉 This PR is included in version 5.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioLozanoM MarioLozanoM MarioLozanoM approved these changes

Assignees
No one assigned
Labels
released on @fix-web-components released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevematney @im-pipeline-bot @MarioLozanoM