Skip to content

fix(env-parsing): ensure struct pointers are initialized before parsing #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbox363 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(env-parsing): ensure struct pointers are initialized before parsing #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cleanenv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,16 @@ func parseValue(field reflect.Value, value, sep string, layout *string) error {

valueType := field.Type()

// Init struct for pointer
if valueType.Kind() == reflect.Ptr && field.IsNil() {
field.Set(reflect.New(valueType.Elem())) // Create the object
}

// Update the field if pointer
if field.Kind() == reflect.Ptr {
field = field.Elem()
}

// look for supported struct parser
// parsing of struct must be done before checking the implementation `encoding.TextUnmarshaler`
// standard struct types already have the implementation `encoding.TextUnmarshaler` (for example `time.Time`)
Expand Down