Refactored BallThread to replace busy-waiting with wait/notify #3303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix busy-waiting loop in BallThread (Twin pattern)
What does this PR do?
This pull request addresses issue #2977, which highlights the use of inefficient busy-waiting loops in some classes.
I have refactored the
BallThread
class in the Twin pattern to replace busy-waiting with a proper synchronization mechanism usingwait()
andnotify()
.Why is this change important?
Changes made
while (isRunning) { if (isSuspended) ... }
pattern with synchronizedwait()
andnotify()
lock
object for thread coordinationsuspendMe()
,resumeMe()
, andstopMe()
methods accordinglyBallThreadTest
Testing
BallThreadTest.java
usingmvn test
Checklist
mvn spotless:apply
to fix formattingFixes #2977
Related Issue
Fixes #2977
Let me know if you'd like help reviewing the PR once it's live — happy to support!