Skip to content
This repository was archived by the owner on Feb 3, 2024. It is now read-only.

Fix tagging workflow #3670

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix tagging workflow #3670

merged 1 commit into from
Jan 26, 2024

Conversation

jrjohnson
Copy link
Member

The pnpm version command doesn't exist. It forwards to npm for some bizare reason. Since we're using pnpm workspaces and not the npm kind this doesn't work for us. Instead we can use this nice tiny npm package update-version to accomplish the same thing and modify the package.json the way we want.

The pnpm version command doesn't exist. It forwards to npm for some
bizare reason. Since we're using pnpm workspaces and not the npm kind
this doesn't work for us. Instead we can use this nice tiny npm package
`update-version` to accomplish the same thing and modify the
package.json the way we want.
@jrjohnson jrjohnson requested a review from stopfstedt January 26, 2024 19:39
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changesets might be worth getting into down the road, but as a quick and easy solution this is great.

LGTM.

@jrjohnson jrjohnson marked this pull request as ready for review January 26, 2024 19:48
@dartajax dartajax merged commit b41ebdb into ilios:master Jan 26, 2024
@jrjohnson jrjohnson deleted the fix-tag-workflow branch January 26, 2024 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants