Skip to content
This repository was archived by the owner on Feb 3, 2024. It is now read-only.

Bump ember-intl from 6.2.2 to 6.3.0 #3625

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2023

Bumps ember-intl from 6.2.2 to 6.3.0.

Release notes

Sourced from ember-intl's releases.

Remove inheritance among helpers

I removed the base helper -format-base.js so that the code for each helper is easier to understand and maintain.

[!IMPORTANT] If you happened to create a helper that extends -format-base.js (private implementation), please extend the Helper class from @ember/component/helper and inject the intl service instead. For reference, please check the {{t}} helper.

Compared to v6.2.2, the unpacked size may be slightly larger (~2 kB). On the plus side, a few type errors and hidden bugs (runtime errors) should be fixed now. Since the code change is large, I went with a minor release to be on the safe side.

[!WARNING] There is a known issue for Glint users, caused by the {{t}} helper returning SafeString and undefined as possible types. This will be addressed soon.

app/templates/form.hbs:1:14 - error TS2345: Argument of type 'string | SafeString | undefined' is not assignable to parameter of type 'string'.
  Type 'undefined' is not assignable to type 'string'.
1 {{page-title (t "routes.form.title")}}
~~~~~~~~~~~~~~~~~~~~~~~
app/templates/form.hbs:6:6 - error TS2322: Type 'string | SafeString | undefined' is not assignable to type 'string | undefined'.
Type 'SafeString' is not assignable to type 'string'.
6     @​instructions={{t
~~~~~~~~~~~~

Changelog

Sourced from ember-intl's changelog.

Changelog for docs-app

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 1, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ember-intl-6.3.0 branch from c1c07ee to fed65ab Compare December 1, 2023 11:07
Bumps [ember-intl](https://github.com/ember-intl/ember-intl) from 6.2.2 to 6.3.0.
- [Release notes](https://github.com/ember-intl/ember-intl/releases)
- [Changelog](https://github.com/ember-intl/ember-intl/blob/main/docs-app/CHANGELOG.md)
- [Commits](ember-intl/ember-intl@v6.2.2...v6.3.0)

---
updated-dependencies:
- dependency-name: ember-intl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ember-intl-6.3.0 branch from fed65ab to 4ab8721 Compare December 1, 2023 11:47
@stopfstedt stopfstedt self-assigned this Dec 1, 2023
@stopfstedt stopfstedt self-requested a review December 1, 2023 17:58
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're not extending the format-base helper in frontend nor common, so no problem here. LGTM.

@stopfstedt stopfstedt merged commit f8cc584 into master Dec 1, 2023
@stopfstedt stopfstedt deleted the dependabot/npm_and_yarn/ember-intl-6.3.0 branch December 1, 2023 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant