Refactor: Move spec outside server#1949
Open
SamuelOliveirads wants to merge 1 commit into
Open
Conversation
Owner
|
Generally looks good, but there is still an issue with the main and draft contexts going out of sync. If I change I.e., at the second accepted batch we get a gap in the sequence of the MTP context. Not showing here, but if I then also log the drafted tokens, I observe that quite often it drafts the same token two times in a row. This leads to the observed unreasonably low acceptance rate. PR #1894 somehow fixes that, but only if the u-batch size is 512 or 256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server currently handles a significant amount of speculative logic, which complicates the implementation and maintenance of new features that aim to replicate this functionality, such as
llama-cliorllama-sweep-bench.The goal here is to migrate as much as possible into the
speculativeandcommonmodules. To ensure consistency, I conducted benchmarks for several models:MTP Full (10 runs × 1500 tokens)
Ngram & Draft Smoke (1 run × 1500 tokens)