Skip to content

Prevent from stackoverflow by limiting length of matched pattern #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent from stackoverflow by limiting length of matched pattern #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/archive/resource/html/ExtractingParseObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class ExtractingParseObserver implements ParseObserver {
boolean inTitle = false;

protected static String cssUrlPatString =
"url\\s*\\(\\s*((?:\\\\?[\"'])?.+?(?:\\\\?[\"'])?)\\s*\\)";
"url\\s*\\(\\s*([^)\\s]{1,8000}?)\\s*\\)";
protected static String cssUrlTrimPatString =
"^(?:\\\\?[\"'])+|(?:\\\\?[\"'])+$";
protected static String cssImportNoUrlPatString =
Expand Down
18 changes: 18 additions & 0 deletions src/test/java/org/archive/resource/html/ExtractingParseObserverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,24 @@ public void testHandleStyleNodeNoHangupTruncated() throws Exception {
checkExtract(test);
}

/**
* Test whether the pattern matcher does not stack overflow with overlong
* sequence of quote characters around a CSS link.
*/
public void testHandleStyleNodeNoStackOverflow() throws Exception {
StringBuilder sb = new StringBuilder();
sb.append("url(");
for (int i = 0; i < 20000; i++)
sb.append('\'');
sb.append("foos.gif");
for (int i = 0; i < 20000; i++)
sb.append('\'');
sb.append(");");
String[] test = new String[1];
test[0] = sb.toString();
checkExtract(test);
}

private void checkExtract(String[] data) throws JSONException {
// System.err.format("CSS(%s) want[0](%s)\n",css,want[0]);
String css = data[0];
Expand Down